Skip to content

Conversation

@eggplants
Copy link
Contributor

I added .ruby-version and refer it from Gemfile and GitHub Actions. Some improvements related to dependencies are also added.

Summary of changes by Copilot

This pull request updates the project's Ruby version and improves dependency management across configuration files, Docker, and CI workflows. The changes ensure consistency in Ruby versioning, enhance automation for dependency updates, and increase the reliability of GitHub Actions by pinning action versions.

Ruby version and dependency management updates:

  • Added a .ruby-version file specifying Ruby version 3.4.8 and updated Gemfile and Dockerfile to use this version for consistency across local development, Docker builds, and CI. (.ruby-version, Gemfile, Dockerfile) [1] [2] [3]
  • Added middleman-cli and ostruct gems to the Gemfile to support CLI functionality and provide additional Ruby utilities. (Gemfile) [1] [2]

Automation and workflow improvements:

  • Updated .github/dependabot.yml to add support for bundler dependency updates, group dependencies by type (production vs. development), and set a cooldown period to avoid frequent PRs. (.github/dependabot.yml)
  • Pinned all GitHub Actions in workflow files (deploy.yml, test.yml) to specific commit SHAs for increased security and reliability, and removed explicit ruby-version settings to rely on .ruby-version. (.github/workflows/deploy.yml, .github/workflows/test.yml) [1] [2] [3]

uses: ruby/setup-ruby@v1
uses: ruby/setup-ruby@8a836efbcebe5de0fe86b48a775b7a31b5c70c93 # v1.277.0
with:
ruby-version: '3.4'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads .ruby-version by default.

Comment on lines +3 to +13
- package-ecosystem: bundler
directory: /
schedule:
interval: 'weekly'
interval: weekly
groups:
dependencies:
dependency-type: production
dev-dependencies:
dependency-type: development
cooldown:
default-days: 7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enables Grouped version updates for Gemfile deps.

@eggplants eggplants marked this pull request as ready for review January 12, 2026 16:47
@hsbt
Copy link
Member

hsbt commented Jan 16, 2026

TryRuby works fine without specifying a version as long as you're using a non-EOL Ruby, so .ruby-version is not necessary.

Is there any particular reason you want to add it?

@eggplants
Copy link
Contributor Author

Main reason is that I would like to use the exactly same version in CI/CD and Gemfile.

Also, since this is a web application and not a library that can be referenced, and it currently does not run on Ruby 4, it's best to keep the Ruby version fixed.

@hsbt
Copy link
Member

hsbt commented Jan 16, 2026

it currently does not run on Ruby 4

Thanks. I fixed that at #227

it's best to keep the Ruby version fixed.

I don't think so. We are not just users but developers, so we actively support new versions includes 4.1.0dev.

@hsbt hsbt closed this Jan 16, 2026
@eggplants eggplants deleted the update-deps branch January 16, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants